Build manpage archive deterministically #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
alexcrichton
force-pushed
the
deterministic
branch
from
ced9e83 to
dc119f6
Compare
|
Thanks, didn't know about that option! Should the entries from |
Keep deterministic builds for Cargo! The changes here are: * Sort files being added to the archive to ensure they're added in the same order on all platforms. * Flag the archive builder as "deterministic mode" which means it won't pick up fields like mtime. Closes rust-lang#8599
alexcrichton
force-pushed
the
deterministic
branch
from
dc119f6 to
624acc8
Compare
|
Aha excellent point, sorting now added too. |
|
Thanks! I wasn't sure if reproducible build environments typically used a special filesystem or not. @bors r+ |
|
📌 Commit 624acc8 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Aug 13, 2020
Update cargo 7 commits in 1653f354644834073d6d2541e27fae94588e685e..ab32ee88dade1b50c77347599e82ca2de3fb8a51 2020-08-04 23:14:37 +0000 to 2020-08-10 17:44:43 +0000 - Build manpage archive deterministically (rust-lang/cargo#8600) - doc: Qualify GNU licenses in example license field (rust-lang/cargo#8604) - Fix jobserver_exists test on single-cpu systems (rust-lang/cargo#8598) - Fix small typo in reference/profiles.md (rust-lang/cargo#8605) - Default cargo publish to the alt registry if it's the only allowed one (rust-lang/cargo#8571) - cargo install with specific yanked version gives confusing "not found" error (rust-lang/cargo#8565) - Fix typo (rust-lang/cargo#8589)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 13, 2020
Update cargo 7 commits in 1653f354644834073d6d2541e27fae94588e685e..ab32ee88dade1b50c77347599e82ca2de3fb8a51 2020-08-04 23:14:37 +0000 to 2020-08-10 17:44:43 +0000 - Build manpage archive deterministically (rust-lang/cargo#8600) - doc: Qualify GNU licenses in example license field (rust-lang/cargo#8604) - Fix jobserver_exists test on single-cpu systems (rust-lang/cargo#8598) - Fix small typo in reference/profiles.md (rust-lang/cargo#8605) - Default cargo publish to the alt registry if it's the only allowed one (rust-lang/cargo#8571) - cargo install with specific yanked version gives confusing "not found" error (rust-lang/cargo#8565) - Fix typo (rust-lang/cargo#8589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep deterministic builds for Cargo!
Closes #8599