Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that OUT_DIR in JSON messages is an absolute path #8403

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Document that OUT_DIR in JSON messages is an absolute path #8403

merged 1 commit into from
Jun 24, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jun 24, 2020

No description provided.

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2020
Eh2406
Eh2406 reviewed Jun 24, 2020
View reviewed changes
src/doc/src/reference/external-tools.md
/* A path which is used as a value of `OUT_DIR` environmental variable
when compiling current package.
/* An absolute path which is used as a value of `OUT_DIR` environmental
variable when compiling current package.
*/
"out_dir": "/some/path/in/target/dir"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this example line be changed to look more like an absolute path?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It starts with a / already, so that should be fine I think.

@Eh2406
Copy link
Contributor

Eh2406 commented Jun 24, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 24, 2020

📌 Commit 39c1081 has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2020
@bors
Copy link
Contributor

bors commented Jun 24, 2020

⌛ Testing commit 39c1081 with merge c7e8663614366bf1f0bfd5010e002e60020f5745...

@bors
Copy link
Contributor

bors commented Jun 24, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2020
@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2020
@bors
Copy link
Contributor

bors commented Jun 24, 2020

⌛ Testing commit 39c1081 with merge 526ea90f2c7e051e0c3264e6cbc97ffd90f51d00...

@bors
Copy link
Contributor

bors commented Jun 24, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2020
@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2020
@bors
Copy link
Contributor

bors commented Jun 24, 2020

⌛ Testing commit 39c1081 with merge 39b48d5...

@bors
Copy link
Contributor

bors commented Jun 24, 2020

☀️ Test successful - checks-azure
Approved by: Eh2406
Pushing 39b48d5 to master...

@bors bors merged commit 39b48d5 into rust-lang:master Jun 24, 2020
@matklad
Copy link
Member Author

matklad commented Jun 30, 2020

So apparently sometimes OUT_DIR is an empty string: rust-lang/rust-analyzer#5125 (comment) Does this sound like a Cargo bug?

@matklad matklad deleted the abs-out-dir branch June 30, 2020 07:56
@alexcrichton
Copy link
Member

Reading over the code I don't think it's possible for out_dir to be an empty string, it's always sourced through something that at the very least does .join("out") on a path. Is there a way perhaps to get a reproduction? If out_dir is coming up empty that sort of sounds like internal memory corruption in Cargo...

@ehuss ehuss mentioned this pull request Jun 30, 2020
Merged
@matklad
Copy link
Member Author

matklad commented Jun 30, 2020

Mystery solved, it is cargo metadata which helpfully sets default value: https://github.com/oli-obk/cargo_metadata/blob/f9d8073c90e2a9254af290313d9118bbeb5fc179/src/messages.rs#L81

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2020
@Manishearth
Rollup merge of rust-lang#73897 - ehuss:update-cargo, r=ehuss
7a48a8e 
Update cargo

## cargo
10 commits in c26576f9adddd254b3dd63aecba176434290a9f6..305eaf0dc5f5a38d6e8041319c2da95b71cf6a4a
2020-06-23 16:21:21 +0000 to 2020-06-30 14:16:08 +0000
- Update core-foundation requirement from 0.7.0 to 0.9.0 (rust-lang/cargo#8432)
- Parse `# env-dep` directives in dep-info files (rust-lang/cargo#8421)
- Move string interning to util (rust-lang/cargo#8419)
- Expose built cdylib artifacts in the Compilation structure (rust-lang/cargo#8418)
- Remove unused serde_derive dependency from the crates.io crate (rust-lang/cargo#8416)
- Remove unused remove_dir_all dependency (rust-lang/cargo#8412)
- Improve git error messages a bit (rust-lang/cargo#8409)
- Improve the description of Config.home_path (rust-lang/cargo#8408)
- Improve support for non-`master` main branches (rust-lang/cargo#8364)
- Document that OUT_DIR in JSON messages is an absolute path (rust-lang/cargo#8403)

## rls
2020-06-19 15:36:00 +0200 to 2020-06-30 23:34:52 +0200
- Update cargo (rust-lang/rls#1686)
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 3, 2020
@bors
Auto merge of rust-lang#73897 - ehuss:update-cargo, r=ehuss
f844ea1 
Update cargo, rls

## cargo
14 commits in c26576f9adddd254b3dd63aecba176434290a9f6..fede83ccf973457de319ba6fa0e36ead454d2e20
2020-06-23 16:21:21 +0000 to 2020-07-02 21:51:34 +0000
- Fix overflow error on 32-bit. (rust-lang/cargo#8446)
- Exclude the target directory from backups using CACHEDIR.TAG (rust-lang/cargo#8378)
- CONTRIBUTING.md: Link to Zulip rather than Discord (rust-lang/cargo#8436)
- Update built-in help for features (rust-lang/cargo#8433)
- Update core-foundation requirement from 0.7.0 to 0.9.0 (rust-lang/cargo#8432)
- Parse `# env-dep` directives in dep-info files (rust-lang/cargo#8421)
- Move string interning to util (rust-lang/cargo#8419)
- Expose built cdylib artifacts in the Compilation structure (rust-lang/cargo#8418)
- Remove unused serde_derive dependency from the crates.io crate (rust-lang/cargo#8416)
- Remove unused remove_dir_all dependency (rust-lang/cargo#8412)
- Improve git error messages a bit (rust-lang/cargo#8409)
- Improve the description of Config.home_path (rust-lang/cargo#8408)
- Improve support for non-`master` main branches (rust-lang/cargo#8364)
- Document that OUT_DIR in JSON messages is an absolute path (rust-lang/cargo#8403)

## rls
2020-06-19 15:36:00 +0200 to 2020-06-30 23:34:52 +0200
- Update cargo (rust-lang/rls#1686)
@ehuss ehuss added this to the 1.46.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eh2406 Eh2406 Eh2406 left review comments

Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matklad @rust-highfive @Eh2406 @bors @alexcrichton @ehuss