-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.44.1 stable backports #8350
1.44.1 stable backports #8350
Conversation
|
(Do we also need to bump the Cargo version or so? Let me know.) |
0287572
to
4e2f1ba
Compare
Hm not sure what's up with the test failures, maybe I broke something? |
This can happen since nightly features periodically break. I don't think anything is wrong at this time, and those failures look pretty benign. We could merge this as failing (which seems fine by me) or the change that fixed this in Cargo could get hunted down and cherry-picked here too |
d41fcac
to
4e2f1ba
Compare
Okay I tried cherry-picking a fix but that didn't seem to fix the tests fully so I've dropped it now. I'm fine with merging with tests not passing, I agree they look benign. |
Mind deleting the tests in question and then this should be r+'able? |
d49ff21
to
a93e48f
Compare
I'm pretty sure this should not include #8290. That regression only applied to beta. |
a93e48f
to
f5681b7
Compare
Ah, sorry for the confusion, I hadn't looked at the exact PR # in zulip. As for the version number, I am ambivalent. If you want to publish a new version, that would be fine. But it probably isn't too important, and this will get picked up in the next release next month anyways. r=me if everyone is ready. |
Seems good to issue a new release, and will give us another run at publish.py -- I bumped to 0.45.1 as I believe there's no API breakage involved in this PR. Can you confirm I don't need to bump any other crates? |
I don't think any other crates need to be changed. |
@bors r=ehuss then, thanks! |
📌 Commit 56d6aad has been approved by |
☀️ Test successful - checks-azure |
Tried to duplicate #8335, though had to manually adjust 3b9e8dc4c1dc6a6ec714acb6a97b4f7cffda1176 (cherry-pick of #8329) as it had a merge conflict.
Stable backports for: