Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary calls to masquerade_as_nightly_cargo. #6923

Merged
merged 1 commit into from
May 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions tests/testsuite/doc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,6 @@ fn doc_edition() {
.file(
"Cargo.toml",
r#"
cargo-features = ["edition"]
[package]
name = "foo"
version = "0.0.1"
Expand All @@ -1153,12 +1152,10 @@ fn doc_edition() {
.build();

p.cargo("doc -v")
.masquerade_as_nightly_cargo()
.with_stderr_contains("[RUNNING] `rustdoc [..]--edition=2018[..]")
.run();

p.cargo("test -v")
.masquerade_as_nightly_cargo()
.with_stderr_contains("[RUNNING] `rustdoc [..]--edition=2018[..]")
.run();
}
Expand All @@ -1169,7 +1166,6 @@ fn doc_target_edition() {
.file(
"Cargo.toml",
r#"
cargo-features = ["edition"]
[package]
name = "foo"
version = "0.0.1"
Expand All @@ -1183,12 +1179,10 @@ fn doc_target_edition() {
.build();

p.cargo("doc -v")
.masquerade_as_nightly_cargo()
.with_stderr_contains("[RUNNING] `rustdoc [..]--edition=2018[..]")
.run();

p.cargo("test -v")
.masquerade_as_nightly_cargo()
.with_stderr_contains("[RUNNING] `rustdoc [..]--edition=2018[..]")
.run();
}
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/edition.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ fn edition_works_for_build_script() {
.file("a/src/lib.rs", "pub fn foo() {}")
.build();

p.cargo("build -v").masquerade_as_nightly_cargo().run();
p.cargo("build -v").run();
}
4 changes: 1 addition & 3 deletions tests/testsuite/fix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -930,9 +930,7 @@ fn fix_idioms() {
fn idioms_2015_ok() {
let p = project().file("src/lib.rs", "").build();

p.cargo("fix --edition-idioms --allow-no-vcs")
.masquerade_as_nightly_cargo()
.run();
p.cargo("fix --edition-idioms --allow-no-vcs").run();
}

#[test]
Expand Down
3 changes: 0 additions & 3 deletions tests/testsuite/install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -780,8 +780,6 @@ fn installs_from_cwd_with_2018_warnings() {
.file(
"Cargo.toml",
r#"
cargo-features = ["edition"]

[package]
name = "foo"
version = "0.1.0"
Expand All @@ -793,7 +791,6 @@ fn installs_from_cwd_with_2018_warnings() {
.build();

p.cargo("install")
.masquerade_as_nightly_cargo()
.with_status(101)
.with_stderr_contains(
"error: Using `cargo install` to install the binaries for the \
Expand Down
9 changes: 0 additions & 9 deletions tests/testsuite/metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1208,8 +1208,6 @@ fn package_edition_2018() {
.file(
"Cargo.toml",
r#"
cargo-features = ["edition"]

[package]
name = "foo"
version = "0.1.0"
Expand All @@ -1219,7 +1217,6 @@ fn package_edition_2018() {
)
.build();
p.cargo("metadata")
.masquerade_as_nightly_cargo()
.with_json(
r#"
{
Expand Down Expand Up @@ -1291,8 +1288,6 @@ fn target_edition_2018() {
.file(
"Cargo.toml",
r#"
cargo-features = ["edition"]

[package]
name = "foo"
version = "0.1.0"
Expand All @@ -1305,7 +1300,6 @@ fn target_edition_2018() {
)
.build();
p.cargo("metadata")
.masquerade_as_nightly_cargo()
.with_json(
r#"
{
Expand Down Expand Up @@ -1389,8 +1383,6 @@ fn rename_dependency() {
.file(
"Cargo.toml",
r#"
cargo-features = ["rename-dependency"]

[project]
name = "foo"
version = "0.0.1"
Expand All @@ -1405,7 +1397,6 @@ fn rename_dependency() {
.build();

p.cargo("metadata")
.masquerade_as_nightly_cargo()
.with_json(
r#"
{
Expand Down
18 changes: 3 additions & 15 deletions tests/testsuite/package.rs
Original file line number Diff line number Diff line change
Expand Up @@ -795,9 +795,7 @@ fn generated_manifest() {
.file("bar/src/lib.rs", "")
.build();

p.cargo("package --no-verify")
.masquerade_as_nightly_cargo()
.run();
p.cargo("package --no-verify").run();

let f = File::open(&p.root().join("target/package/foo-0.0.1.crate")).unwrap();
let rewritten_toml = format!(
Expand Down Expand Up @@ -949,11 +947,6 @@ fn test_edition() {
.build();

p.cargo("build -v")
.masquerade_as_nightly_cargo()
.without_status() // passes on nightly, fails on stable, b/c --edition is nightly-only
// --edition is still in flux and we're not passing -Zunstable-options
// from Cargo so it will probably error. Only partially match the output
// until stuff stabilizes
.with_stderr_contains(
"\
[COMPILING] foo v0.0.1 ([..])
Expand Down Expand Up @@ -1086,9 +1079,7 @@ fn package_with_select_features() {
)
.build();

p.cargo("package --features required")
.masquerade_as_nightly_cargo()
.run();
p.cargo("package --features required").run();
}

#[test]
Expand Down Expand Up @@ -1117,9 +1108,7 @@ fn package_with_all_features() {
)
.build();

p.cargo("package --all-features")
.masquerade_as_nightly_cargo()
.run();
p.cargo("package --all-features").run();
}

#[test]
Expand Down Expand Up @@ -1149,7 +1138,6 @@ fn package_no_default_features() {
.build();

p.cargo("package --no-default-features")
.masquerade_as_nightly_cargo()
.with_stderr_contains("error: This crate requires `required` feature!")
.with_status(101)
.run();
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/rename_deps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ fn lots_of_names() {
.file("foo/src/lib.rs", "pub fn foo4() {}")
.build();

p.cargo("build -v").masquerade_as_nightly_cargo().run();
p.cargo("build -v").run();
}

#[test]
Expand Down