Stabilize the rename-dependency feature
#6311
Conversation
This commit stabilizes Cargo's `rename-dependency` feature which allows renaming packages in `Cargo.toml`, enabling importing multiple versions of a single crate or simply avoiding a `use foo as bar` in `src/lib.rs`. Closes rust-lang#5653
|
@rfcbot fcp merge |
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
From the issue it doesn't look like there is anything left to do except remove the feature gate and move the docs. Summary of the feature (please correct me if I'm wrong): allows adding a Motivation for doing this now is that it allows users to rename crates without using AFAIK, there are no open questions. (An obvious alternative would be to use the package name as the dependency name and add a |
|
Ah yes sorry @nrc, should have included that in the OP! The docs should be moved here and updated slightly as well, but nothing major changed. As for your summary, you're spot on! As for |
|
Before I check my box, can we confirm that this can be solved on the cratis.io side? |
|
@Eh2406 crates.io definitely has enough information to solve that eventually, although it will take some effort to do so. |
|
How does this relate to public dependencies? I assume that the unification of public dependencies would be based on the un-aliased name? |
|
@wycats That was my understanding. I can try to find it in the RFC discussion if you'd like. |
|
@Eh2406 is correct, this shouldn't affect public/private in the sense that this is basically just a local renaming for the crate in question, but all the same public/private rules are in effect for the actual package itself, regardless of what each crate decides to call it. |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 psst @alexcrichton, I wasn't able to add the |
dwijnand
added
the
final-comment-period
|
@bors: r=the-whole-team |
|
📌 Commit 1533a04 has been approved by |
|
⌛ Testing commit 1533a04 with merge af1814e77f0a1837f9ef1ab492c9b72371b30873... |
|
💥 Test timed out |
|
@bors: retry |
|
⌛ Testing commit 1533a04 with merge bf52011a573c5ae088974d1ef61774637ea8a2b5... |
|
Huh. Is "the-whole-team" a magic string, or does bors accept anything as the value of |
|
💥 Test timed out |
|
It accepts anything, and only checks who writes the command. |
|
@bors: r=the-whole-team |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 1533a04 has been approved by |
Stabilize the `rename-dependency` feature This commit stabilizes Cargo's `rename-dependency` feature which allows renaming packages in `Cargo.toml`, enabling importing multiple versions of a single crate or simply avoiding a `use foo as bar` in `src/lib.rs`. Closes #5653
|
☀️ Test successful - status-appveyor, status-travis |
[beta] Stabilize the `rename-dependency` feature This is a backport of #6311
This commit stabilizes Cargo's
rename-dependencyfeature which allowsrenaming packages in
Cargo.toml, enabling importing multiple versionsof a single crate or simply avoiding a
use foo as barinsrc/lib.rs.Closes #5653