Cop out on fixing a spurious test failure #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cops out trying to fix `rename_with_link_search_path` by simply adding a loop on Windows to retry the operation that looks to need retrying.
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced May 5, 2018
|
@bors r+ |
|
📌 Commit 1759b30 has been approved by |
bors
added a commit
that referenced
this pull request
May 5, 2018
Cop out on fixing a spurious test failure This commit cops out trying to fix `rename_with_link_search_path` by simply adding a loop on Windows to retry the operation that looks to need retrying.
|
Just FYI, I put this through a stress test on AppVeyor (here) and it seems to pass just fine (with some warnings)! 🎉 |
|
Awesome, thanks @ehuss! Hopefully we don't have to put this logic in too many places... |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cops out trying to fix
rename_with_link_search_pathby simplyadding a loop on Windows to retry the operation that looks to need retrying.