Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Cargo.toml in manifest help description #5352

Merged
merged 2 commits into from
Apr 12, 2018

Conversation

surma
Copy link
Contributor

@surma surma commented Apr 12, 2018

I was looking for a CLI flag to pass a different TOML to cargo, but didn’t realize it’s called “manifest” from reading the help.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -73,7 +73,7 @@ Build for the target triple.
.RE
.TP
.B \-\-manifest\-path \f[I]PATH\f[]
Path to the manifest to compile.
Path to the manifestsrc/etc/man/cargo-doc.1 to compile.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Path to the manifest (Cargo.toml)?

Also, I'd just simplified all instances to path to the Cargo.toml: the flag name already mentions manifest, no need to repeat that :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... When copy/paste goes wrong. I wanted to do that, but didn’t want to take too many liberties. Will fix.

@matklad
Copy link
Member

matklad commented Apr 12, 2018

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 12, 2018

📌 Commit f575a6d has been approved by matklad

bors added a commit that referenced this pull request Apr 12, 2018
Mention Cargo.toml in manifest help description

I was looking for a CLI flag to pass a different TOML to cargo, but didn’t realize it’s called “manifest” from reading the help.
@bors
Copy link
Contributor

bors commented Apr 12, 2018

⌛ Testing commit f575a6d with merge df11567...

@bors
Copy link
Contributor

bors commented Apr 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing df11567 to master...

@bors bors merged commit f575a6d into rust-lang:master Apr 12, 2018
@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants