-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention Cargo.toml in manifest help description #5352
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/etc/man/cargo-doc.1
Outdated
@@ -73,7 +73,7 @@ Build for the target triple. | |||
.RE | |||
.TP | |||
.B \-\-manifest\-path \f[I]PATH\f[] | |||
Path to the manifest to compile. | |||
Path to the manifestsrc/etc/man/cargo-doc.1 to compile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Path to the manifest (Cargo.toml)
?
Also, I'd just simplified all instances to path to the Cargo.toml
: the flag name already mentions manifest, no need to repeat that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... When copy/paste goes wrong. I wanted to do that, but didn’t want to take too many liberties. Will fix.
@bors r+ Thanks! |
📌 Commit f575a6d has been approved by |
Mention Cargo.toml in manifest help description I was looking for a CLI flag to pass a different TOML to cargo, but didn’t realize it’s called “manifest” from reading the help.
☀️ Test successful - status-appveyor, status-travis |
I was looking for a CLI flag to pass a different TOML to cargo, but didn’t realize it’s called “manifest” from reading the help.