Fix cargo test --doc not testing examples
#2685
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! Could you be sure to add a test for this as well? |
|
@alexcrichton I've updated your test to validate the output, but I've been unable to resolve the issue where a test fails when testing with Rust Beta on OS X. Is it something wrong with my changes, or does test_cargo_doc::doc_multiple_deps just not clean up properly? Edit: |
Fix `cargo test --doc` not testing examples When running cargo doc --test in a project folder, cargo does not test documentation examples, it only builds the project and exits. Refer to issue #2684
|
💔 Test failed - cargo-win-gnu-32 |
|
@bors: retry On Tue, May 17, 2016 at 10:00 AM, bors [email protected] wrote:
|
|
⚡ Previous build results for cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 are reusable. Rebuilding only cargo-win-gnu-32... |
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
When running cargo doc --test in a project folder, cargo does not test documentation examples, it only builds the project and exits.
Refer to issue #2684