Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config paths to only check CARGO_HOME for cargo-script #14749

Merged
merged 1 commit into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/bin/cargo/commands/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,8 @@ pub fn exec_manifest_command(gctx: &mut GlobalContext, cmd: &str, args: &[OsStri

let manifest_path = root_manifest(Some(manifest_path), gctx)?;

// Treat `cargo foo.rs` like `cargo install --path foo` and re-evaluate the config based on the
// location where the script resides, rather than the environment from where it's being run.
let parent_path = manifest_path
.parent()
.expect("a file should always have a parent");
gctx.reload_rooted_at(parent_path)?;
// Reload to cargo home.
gctx.reload_rooted_at(gctx.home().clone().into_path_unlocked())?;

let mut ws = Workspace::new(&manifest_path, gctx)?;
if gctx.cli_unstable().avoid_dev_deps {
Expand Down
42 changes: 33 additions & 9 deletions tests/testsuite/script.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
use std::fs;

use cargo_test_support::basic_manifest;
use cargo_test_support::paths::cargo_home;
use cargo_test_support::prelude::*;
use cargo_test_support::registry::Package;
use cargo_test_support::str;
Expand Down Expand Up @@ -300,7 +303,7 @@ msg = hello
}

#[cargo_test]
fn use_script_config() {
fn use_cargo_home_config() {
let script = ECHO_SCRIPT;
let _ = cargo_test_support::project()
.at("script")
Expand All @@ -318,26 +321,47 @@ rustc = "non-existent-rustc"
.file("script.rs", script)
.build();

// Verify the config is bad
// Verify that the config from the current directory is used
p.cargo("-Zscript script.rs -NotAnArg")
.masquerade_as_nightly_cargo(&["script"])
.with_status(101)
.with_stderr_data(str![[r#"
[ERROR] could not execute process `non-existent-rustc -vV` (never executed)

Caused by:
[NOT_FOUND]
.with_stdout_data(str![[r#"
bin: [ROOT]/home/.cargo/target/[HASH]/debug/script[EXE]
args: ["-NotAnArg"]

"#]])
.run();

// Verify that the config isn't used
// Verify that the config from the parent directory is not used
p.cargo("-Zscript ../script/script.rs -NotAnArg")
.masquerade_as_nightly_cargo(&["script"])
.with_stdout_data(str![[r#"
bin: [ROOT]/home/.cargo/target/[HASH]/debug/script[EXE]
args: ["-NotAnArg"]

"#]])
.run();

// Write a global config.toml in the cargo home directory
let cargo_home = cargo_home();
fs::write(
&cargo_home.join("config.toml"),
r#"
[build]
rustc = "non-existent-rustc"
"#,
)
.unwrap();

// Verify the global config is used
p.cargo("-Zscript script.rs -NotAnArg")
.masquerade_as_nightly_cargo(&["script"])
.with_status(101)
.with_stderr_data(str![[r#"
[ERROR] could not execute process `non-existent-rustc -vV` (never executed)

Caused by:
[NOT_FOUND]

"#]])
.run();
}
Expand Down