Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.85.0; update changelog #14695

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

weihanglo
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2024
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to r= me. I find it unlikely that I'll need to re-review.

CHANGELOG.md Outdated

### Internal

- Several resolver performance enhancements, including
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf changes are user facing, seems like putting these under Internal will hide them

CHANGELOG.md Outdated
For compatibility with earlier MSRV,
consdier setting the `package.rust-version` to 1.82 or earlier.
[#14595](https://github.com/rust-lang/cargo/pull/14595)
- cargo-package: Now fails fast if the package version is already published.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for cargo publish. The PR title refers to the packaging step

CHANGELOG.md Outdated
[#14451](https://github.com/rust-lang/cargo/pull/14451)
- Suggest `cargo info` command in the `cargo search` result
[#14537](https://github.com/rust-lang/cargo/pull/14537)
- Improved error reporting when a feature is not found in `activated_features`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a variable name in the public facing changes seems odd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this panic message is public facing, this seems more like an internal/nightly stuff. AFAIK only things like -Zbindeps hit this and the message still exposes internal debug representation.

Moved to under internals.

CHANGELOG.md Outdated
- cargo-new: only auto-add new packages to the workspace relative to the manifest,
rather than the current directory.
[#14505](https://github.com/rust-lang/cargo/pull/14505)
- cargo-package: Don't automatically include the current crate when packaging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"include" can also be read as "in the tarball". I was confused by this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ❗️ cargo-package: When using the `--package` flag, only the specified
  packages are packaged. Previously, the package in the current working
  directory was automatically selected for packaging.

After re-read the PR I think it justifies to have a compatibility note.

Moved to Changed with a big ❗️.

BTW, I didn't mention --manifest-path at all, although it is the package from either cwd or --manifest-path would be auto selected. That goes too detailed and I don't feel worthy.

@weihanglo weihanglo force-pushed the version-bump branch 2 times, most recently from 0dd1c54 to bf1e7a4 Compare October 16, 2024 01:35
@weihanglo
Copy link
Member Author

@bors r=epage

@bors
Copy link
Contributor

bors commented Oct 16, 2024

📌 Commit 21826b3 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2024
@bors
Copy link
Contributor

bors commented Oct 16, 2024

⌛ Testing commit 21826b3 with merge ca14836...

@bors
Copy link
Contributor

bors commented Oct 16, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing ca14836 to master...

@bors bors merged commit ca14836 into rust-lang:master Oct 16, 2024
24 checks passed
@weihanglo weihanglo deleted the version-bump branch October 16, 2024 03:11
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2024
Update cargo

7 commits in 8c30ce53688e25f7e9d860b33cc914fb2957ca9a..cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5
2024-10-15 16:43:16 +0000 to 2024-10-18 13:56:15 +0000
- feat: Stabilize MSRV-aware resolver config (rust-lang/cargo#14639)
- Help with `[patch.crates.io]` (rust-lang/cargo#14700)
- test: Migrate publish snapshotting to snapbox (rust-lang/cargo#14642)
- Bump to 0.85.0; update changelog (rust-lang/cargo#14695)
- Fix typo in faq.md (rust-lang/cargo#14696)
- fix(registry): `HttpRegistry` `block_until_ready` returns early when work is still pending (rust-lang/cargo#14694)
- fix(resolver): avoid cloning when iterating using RcVecIter (rust-lang/cargo#14690)
@rustbot rustbot added this to the 1.84.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants