Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): Don't double-warn about $CARGO_HOME/config #14579

Merged
merged 3 commits into from
Sep 26, 2024
Merged

fix(config): Don't double-warn about $CARGO_HOME/config #14579

merged 3 commits into from
Sep 26, 2024
+27 −6

Commits on Sep 25, 2024

  1. test: Add test for issue-14560

    @linyihai
    linyihai committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d5cb6b5 View commit details
    Browse the repository at this point in the history

  2. refactor(config): Clarify duplicate-load check

    @epage
    epage committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0b83e92 View commit details
    Browse the repository at this point in the history

  3. fix(config): Don't double-warn about $CARGO_HOME/config 

    The core requirements for this bug are
- You have a `$CARGO_HOME/.config`
- Your project is inside of `$HOME`

We have a check to make sure we don't double-walk `$CARGO/config` but
that check is *after* we warn about there being no `.toml` extension.

To fix this, we just need to move that check outside of the file lookup.
This required changing the `seen` check from checking whether walked the
config file to checking if we've walked the config dir.  As we only have
one file per directory, this should work.
    @epage
    epage committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fe917f2 View commit details
    Browse the repository at this point in the history