Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toml): Validate crates_types/proc-macro for bin like others #13841

Merged
merged 8 commits into from
May 2, 2024
Merged

fix(toml): Validate crates_types/proc-macro for bin like others #13841

merged 8 commits into from
May 2, 2024

Commits on Apr 29, 2024

  1. refactor(toml): Pull bin crate-types validation out

    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f715156 View commit details
    Browse the repository at this point in the history

  2. refactor(toml): Pull bin proc-macro validation out

    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    330d5ea View commit details
    Browse the repository at this point in the history

  3. refactor(toml): Validate bin in resolve, like other targets

    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    640d41d View commit details
    Browse the repository at this point in the history

  4. refactor(toml): Group related validation functions

    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    72b170e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. test(toml): Scope proc_macro2 tests to libs

    @epage
    epage committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d59e7a3 View commit details
    Browse the repository at this point in the history

  2. test(toml): Show underscore behavior for bin targets

    @epage
    epage committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2c31fe3 View commit details
    Browse the repository at this point in the history

  3. fix(toml): Validate crates_types/proc-macro for bin like others 

    Turns out, we allow these fields, just in limited ways, so we need to be
consistent.

I limited when this applies to reduce noise from the user solving there
problem because they are unlikely to keep the field and switch it to the
opposite value
    @epage
    epage committed May 2, 2024
    Configuration menu
    Copy the full SHA
    fe0819e View commit details
    Browse the repository at this point in the history

  4. refactor(toml): Consistently document motivation for validation order

    @epage
    epage committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cdae596 View commit details
    Browse the repository at this point in the history