-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: don't compress test registry crates #13744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are still nominally gzipped, but using `Compression::none()` makes them consistent even across zlib and zlib-ng, and this fixes checksum differences in the testsuite. There is a one-time update of all those checksums to catch up with this change though.
rustbot
added
A-testing-cargo-itself
Area: cargo's tests
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2024
weihanglo
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty clever! Thank you!
Tried turning @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2024
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2024
Update cargo 8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08 2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000 - test: Remove add/remove death tests (rust-lang/cargo#13750) - feat(resolve): Fallback to 'rustc -V' for MSRV resolving (rust-lang/cargo#13743) - feat(cli): Add --ignore-rust-version to update/generate-lockfile (rust-lang/cargo#13742) - `cargo package -p no-exist` emitt error when the -p `package` not found (rust-lang/cargo#13735) - fix(help): Generalize --ignore-rust-version (rust-lang/cargo#13741) - test: don't compress test registry crates (rust-lang/cargo#13744) - feat(reslve): Respect '--ignore-rust-version' (rust-lang/cargo#13738) - refactor: Remove `rust_2024_compatibility` lint group (rust-lang/cargo#13740) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2024
Update cargo 8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08 2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000 - test: Remove add/remove death tests (rust-lang/cargo#13750) - feat(resolve): Fallback to 'rustc -V' for MSRV resolving (rust-lang/cargo#13743) - feat(cli): Add --ignore-rust-version to update/generate-lockfile (rust-lang/cargo#13742) - `cargo package -p no-exist` emitt error when the -p `package` not found (rust-lang/cargo#13735) - fix(help): Generalize --ignore-rust-version (rust-lang/cargo#13741) - test: don't compress test registry crates (rust-lang/cargo#13744) - feat(reslve): Respect '--ignore-rust-version' (rust-lang/cargo#13738) - refactor: Remove `rust_2024_compatibility` lint group (rust-lang/cargo#13740) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testing-cargo-itself
Area: cargo's tests
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are still nominally gzipped, but using
Compression::none()
makesthem consistent even across zlib and zlib-ng, and this fixes checksum
differences in the testsuite. There is a one-time update of all those
checksums to catch up with this change though.
r? @weihanglo