Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global_cache_tracker stability tests. #13467

Merged
merged 6 commits into from
Feb 21, 2024

Commits on Feb 20, 2024

  1. Fix bug in GlobalCacheTracker::git_checkout_all

    This fixes a bug in the `GlobalCacheTracker::git_checkout_all` function
    which was using the wrong SQL column name. This function belongs to the
    set of of functions only used for testing, and this particular function
    was not yet used.
    ehuss committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    7e5ab66 View commit details
    Browse the repository at this point in the history
  2. Add Execs::args

    This adds the `Execs::args` method which forwards to
    `ProcessBuilder::args` to specify multiple command arguments at once.
    ehuss committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f9ba89b View commit details
    Browse the repository at this point in the history
  3. cargo_test CI macro: add requires_rustup_stable

    This adds the `requires_rustup_stable` option to the cargo_test macro to
    require `rustup` to exist, and for the `stable` toolchain to be
    installed.
    
    It is required that stable be installed in Cargo's CI. On a developer
    machine, the tests will be ignored if rustup is not installed. It will
    also be ignored on rust-lang/rust's CI since it does not have rustup.
    ehuss committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8bb6231 View commit details
    Browse the repository at this point in the history
  4. Add global_cache_tracker stability tests.

    This adds some tests to ensure that the database used in the global
    cache tracker stays compatible across versions. These tests work by
    using rustup to run both the current cargo and the stable cargo, and
    verifying that when switching versions, everything works as expected.
    ehuss committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9f71231 View commit details
    Browse the repository at this point in the history
  5. Add workaround for RUSTUP_WINDOWS_PATH_ADD_BIN.

    On Windows, rustup has an issue with recursive cargo invocations. This
    commit can be removed once
    rust-lang/rustup#3036 is resolved.
    ehuss committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ccaa118 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Fix path issues for running rustup wrapper on Windows.

    Cargo likes to modify PATH, which circumvents the ability to choose the
    correct "cargo" executable to run on Windows (because Windows uses PATH
    for both binary and shared library searching).
    ehuss committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a82794e View commit details
    Browse the repository at this point in the history