Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json-msg): use pkgid spec in in JSON messages #13311

Merged
merged 3 commits into from
Jan 17, 2024
Merged

fix(json-msg): use pkgid spec in in JSON messages #13311

merged 3 commits into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. fix(json-msg): use pkgid spec in in JSON messages 

    In 12914 we stabilized pkgid spec as unique package identifier for
`cargo metadata`. However, we forgot to make the same change to
JSON message format[^1]. This PR does so.

Note that the `package_id` field in JSON message is not clearly stated
as "opaque", so it might be considered as a breaking change to some extent.

[^1]: https://doc.rust-lang.org/nightly/cargo/reference/external-tools.html#compiler-messages
    @weihanglo
    weihanglo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f9fd4ff View commit details
    Browse the repository at this point in the history

  2. docs(json-msg): pkgid spec as package_id

    @weihanglo
    weihanglo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b5457ac View commit details
    Browse the repository at this point in the history

  3. docs: more links to JSON messages

    @weihanglo
    weihanglo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ad1a3b3 View commit details
    Browse the repository at this point in the history