Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): Suggest an alternative version on MSRV failure #12798

Merged
merged 3 commits into from
Oct 10, 2023

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    699b30a View commit details
    Browse the repository at this point in the history
  2. fix(install): Don't suggest --locked for MSRV when its root package

    This will also report the error without having to download the `.crate`
    first.
    
    If installing multiple packages, this will also report it immediately,
    rather than waiting for the other packages to be installed first.
    
    This also offers us more flexibility in the error we report,
    like suggesting more appropriate fixes.
    epage committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2976e2a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. fix(install): Suggest an alternative version on MSRV failure

    The next step would be to also automatically install an MSRV compatible
    version if compatible with the version req (rust-lang#10903).
    This improved error message will still be useful if the MSRV compatible
    version is outside of the version req.
    
    I did this as the first step
    - Helps people now, not needing to wait on `-Zmsrv-policy` to be stabilized
    - Has fewer questions on how it should be done (or if it should be)
    epage committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9b32be7 View commit details
    Browse the repository at this point in the history