Fix cfg of platform-specific tests #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⌛ Testing commit c8f4ecc with merge d2a455f... |
|
💔 Test failed - cargo-win-32 |
|
Travis is reporting failures on linux (on tests I haven't touched and also the build stalled), and homu is reporting a timeout for win32. On my linux box everything works fine. Not sure what's wrong... |
|
Ah yeah these failures are benign. |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jan 5, 2015
For two tests, the `Cargo.toml`s and the `cfg`s don't match. E.g., the first test expects a successful build on all linux platforms but its `toml` is prepared for Intel linuxes only. The second test is very similar. Here, the `cfg`s are amended to match the `toml`s.
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For two tests, the
Cargo.tomls and thecfgs don't match. E.g., the first test expects a successful build on all linux platforms but itstomlis prepared for Intel linuxes only. The second test is very similar.Here, the
cfgs are amended to match thetomls.