Search upward if the path does not exist when cargo new
#10987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-vcs
branch
from
8bf7afe
to
379c351
Compare
epage
reviewed
Aug 15, 2022
| // Try to find the first existing parent of the path. | ||
| // Otherwise, we can't find the git repo when the path has non-existing parent directories. | ||
| let mut first_exist_base_path = Some(path); | ||
| while let Some(p) = first_exist_base_path { |
There was a problem hiding this comment.
See instead libgit2/libgit2#6383
There was a problem hiding this comment.
Yes. See instead #10981 (comment).
weihanglo
added
S-blocked
and removed
S-waiting-on-review
weihanglo
added
S-blocked-external
|
Hello. I am going to close this, as we agree on waiting for an upstream fix, and this is not really a severe bug. Thank you for the patch anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to Search upward if the path does not exist when
cargo new.What does this PR try to resolve?
close #10981
How should we test and review this PR?
Run the unit test or try the case which comes from the issue.