Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add argument --counts to run repeated tests, benchmarks #10174

Closed
wants to merge 2 commits into from

Conversation

contrun
Copy link

@contrun contrun commented Dec 6, 2021

This should fix rust-lang/rust#65218.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2021
@contrun contrun force-pushed the add-counts-for-test branch from 2f907b7 to 5db9637 Compare December 6, 2021 11:34
@contrun contrun changed the title add argument --counts to run repeated tests add argument --counts to run repeated tests, benchmarks Dec 6, 2021
@ehuss
Copy link
Contributor

ehuss commented Dec 7, 2021

Thanks for the PR!

We were wondering, would it be possible to make this part of libtest instead? It seems like something that the test runner should be concerned with.

@contrun
Copy link
Author

contrun commented Dec 8, 2021

@ehuss Thanks for the information. I will take a look at libtest when I have time.

@bors
Copy link
Contributor

bors commented Feb 22, 2022

☔ The latest upstream changes (presumably #10408) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss
Copy link
Contributor

ehuss commented Mar 23, 2022

Closing as this is a bit old, and it is not clear which direction is best for implementing something like this.

@ehuss ehuss closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: test binaries should support repeating runs
4 participants