Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description of the targets that can be applied #10109

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Description of the targets that can be applied #10109

merged 1 commit into from
Nov 29, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Nov 22, 2021 •
edited
Loading

close #9806

Adds a description of the targets to which the default profile can be applied.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2021
@ehuss ehuss assigned ehuss and unassigned Eh2406 Nov 22, 2021
@ehuss
Copy link
Contributor

ehuss commented Nov 22, 2021

Thanks for the PR! I was wondering if you'd be willing to rework this a little to make it clearer? I'm concerned that calling out examples in the dev profile this way may be misleading, as the profile used for examples will depend on the command and flags being used.

I was thinking that instead a new paragraph could be added to the "Profile selection" section. Perhaps add a sentence or two somewhere that explains that the profile selected applies to all Cargo targets, and include a list of target names (library, bins, examples, tests, benchmarks) so that if someone is searching by term they will find it.

@Rustin170506 Rustin170506 force-pushed the rustin-patch-docs-profile branch from aa0e7dc to c066a23 Compare November 28, 2021 06:00
@Rustin170506 Rustin170506 changed the title Document profile used to build examples Document of the targets that can be applied Nov 28, 2021
@Rustin170506 Rustin170506 changed the title Document of the targets that can be applied Description of the targets that can be applied Nov 28, 2021
@Rustin170506
Copy link
Member Author

Rustin170506 commented Nov 28, 2021 •
edited
Loading

@ehuss Updated.
Thanks for your review! 💚 💙 💜 💛 ❤️

@ehuss
Copy link
Contributor

ehuss commented Nov 29, 2021

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 29, 2021

📌 Commit c066a23 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2021
@bors
Copy link
Contributor

bors commented Nov 29, 2021

⌛ Testing commit c066a23 with merge 26105a4...

@bors
Copy link
Contributor

bors commented Nov 29, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 26105a4 to master...

@bors bors merged commit 26105a4 into rust-lang:master Nov 29, 2021
@ehuss ehuss mentioned this pull request Nov 30, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2021
@bors
Auto merge of rust-lang#91379 - ehuss:update-cargo, r=ehuss
4c94896 
Update cargo

6 commits in 7f08ace4f1305de7f3b1b0e2f765911957226bd4..294967c53f0c70d598fc54ca189313c86c576ea7
2021-11-24 17:54:39 +0000 to 2021-11-29 19:04:22 +0000
- Fix some tests with output collisions. (rust-lang/cargo#10137)
- Description of the targets that can be applied (rust-lang/cargo#10109)
- Improve unused patch message when source URLs mismatched (rust-lang/cargo#10130)
- Add a note about doctest xcompile. (rust-lang/cargo#10132)
- book: add edit links to specific pages (rust-lang/cargo#10124)
- Add crate type flag to rustc command (rust-lang/cargo#10093)
@ehuss ehuss added this to the 1.59.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

Document profile(s) used to build examples
5 participants
@Rustin170506 @rust-highfive @ehuss @bors @Eh2406