Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please publish new version of cargo-platform to include the license files #9758

Closed
erickt opened this issue Aug 3, 2021 · 1 comment · Fixed by #9762
Closed

Please publish new version of cargo-platform to include the license files #9758

erickt opened this issue Aug 3, 2021 · 1 comment · Fixed by #9762
Labels
A-cargo-api Area: cargo-the-library API and internal code issues C-bug Category: bug

Comments

@erickt
Copy link
Contributor

erickt commented Aug 3, 2021

The published version of cargo-platform does not include the LICENSE-APACHE or LICENSE-MIT files, which can be seen on https://docs.rs/crate/cargo-platform/0.1.1/source/. Could a new version be published that includes these files? This makes it much easier to audit that the code to make sure it is correctly licensed.

There were also a handful of small clippy fixes since cargo-platform was last published, but as best as I can tell, they don't appear to be significant changes.

Possible Solution(s)

It appears that all we need to do to address this is to:

  • Bump the cargo-platform to 0.1.2
  • Verify that cargo publish --list includes LICENSE-APACHE and LICENSE-MIT
  • Publish cargo-platform 0.1.2

Thanks so much!
@erickt erickt added the C-bug Category: bug label Aug 3, 2021
@ehuss
Copy link
Contributor

ehuss commented Aug 4, 2021

Feel free to post a PR to bump the version, and I can publish it.

@ehuss ehuss added the A-cargo-api Area: cargo-the-library API and internal code issues label Aug 4, 2021
@erickt erickt mentioned this issue Aug 4, 2021
Merged
bors added a commit that referenced this issue Aug 5, 2021
@bors
Auto merge of #9762 - erickt:bump, r=ehuss
9815087 
Update cargo-platform to 0.1.2

This preps cargo-platform for a release. The only substantial change is that this should include the license files into the archive that is uploaded to crates.io.

Closes #9758
@bors bors closed this as completed in f71b231 Aug 5, 2021
@erickt erickt mentioned this issue Aug 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cargo-api Area: cargo-the-library API and internal code issues C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cargo-platform to 0.1.2 erickt/cargo
2 participants
@ehuss @erickt