Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index hash has changed #8572

Closed
ehuss opened this issue Jul 31, 2020 · 0 comments · Fixed by #8573
Closed

index hash has changed #8572

ehuss opened this issue Jul 31, 2020 · 0 comments · Fixed by #8573
Labels
A-caching Area: caching of dependencies, repositories, and build artifacts

Comments

@ehuss
Copy link
Contributor

ehuss commented Jul 31, 2020

As a result of #8522 changing the hash computation, the crates.io index path has changed from the long-running github.aaakk.us.kg-1ecc6299db9ec823 to github.aaakk.us.kg-f1e60147b9cdaa30. My main concern here is the increase in disk usage, since these tend to be kinda weighty (the new one is 81MB, my old one had accumulated 230MB).

I'm wondering if it would be better to try to match the old hash for this circumstance? Since Cargo doesn't have any sort of built-in garbage collection, the old index will persist unless the user manually deletes it.
@ehuss ehuss added the A-caching Area: caching of dependencies, repositories, and build artifacts label Jul 31, 2020
@alexcrichton alexcrichton mentioned this issue Jul 31, 2020
Merged
bors added a commit that referenced this issue Jul 31, 2020
@bors
Auto merge of #8573 - alexcrichton:hash-same, r=ehuss
2d5c238 
Use the same index location on nightly as beta

Closes #8572
@bors bors closed this as completed in 6f29fb7 Jul 31, 2020
@matthiaskrgr matthiaskrgr mentioned this issue Aug 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-caching Area: caching of dependencies, repositories, and build artifacts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the same index location on nightly as beta alexcrichton/cargo
1 participant
@ehuss