Tracking issues for the `-Zmultitarget` feature #8176

alexcrichton · 2020-04-28T19:34:37Z

This is intended to be a tracking issue for -Zmultitarget being implemented in #8167. This feature allows passing the --target flag multiple times to Cargo to build code simultaneously for multiple targets. This was originally requested in #8156 and #3913.

Currently the semantics of -Zmultitarget is that it simply allows passing --target multiple times (2 or more) to Cargo. Cargo recognizes this as doing what it was already doing, only now for multiple targets instead of just a single target. Internally Cargo's unit graph should still have all the edges drawn correctly and whatnot.

The text was updated successfully, but these errors were encountered:

4ad · 2020-11-24T12:22:50Z

How is this supposed to interact with the (currently single) target specification in config.toml?

alexcrichton · 2020-11-24T15:21:53Z

I think we'd probably want to implement support for build.target = ["array", "of", "targets"]

4ad · 2020-11-24T15:52:21Z

SGTM.

khionu · 2021-07-25T03:35:14Z

Just saw that the referenced PR is closed. Are there any pending steps before closing this issue?

Jasper-Bekkers · 2022-02-27T10:20:11Z

Just saw that the referenced PR is closed. Are there any pending steps before closing this issue?

I'm also curious about potential next steps on this issue, as we're trying to streamline the Android development experience.

edwincoronado · 2022-03-09T20:13:36Z

I have a config.toml file that looks like this:

[unstable]
multitarget = true

[build]
target = ["nightly", "nightly-i686-unknown-linux-gnu"]

but getting an error "build.target" expected a string, but found a array, using the cli --target argument is really not an option for me since I'm using workspaces for a large project.

Does anybody know a workaround?

weihanglo · 2022-06-18T05:58:35Z

-Zmultitarget exists on nightly for years (#8167, merged in April 2020). It has already been in the wild for a long time, and is the main code path of cargo compilation since then. The support of multitarget in .cargo/config.toml has landed (March 2022 #10473) with only minimal additions.

It may be the time to push it to stable. #10766 tries to stabilize it. Need some inputs from others.

@rfcbot fcp merge

rfcbot · 2022-06-18T05:58:36Z

Team member @weihanglo has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2022-06-28T16:09:46Z

🔔 This is now entering its final comment period, as per the review above. 🔔

ehuss · 2022-06-28T19:09:28Z

One note I wanted to point out is that cargo doc and cargo install do not support multiple targets. I do not think that is a blocker for stabilizing, but is something that may want to be considered in the future if those are things someone wants.

It is also not supported by the unstable artifact-dependencies and per-package-target feature (in the sense that they only allow selecting a single target). Also not a blocker, and also can be added at any time in the future. Just trying to note that this has a ripple effect across other features.

khionu · 2022-06-28T23:05:48Z

One note I wanted to point out is that cargo doc and cargo install do not support multiple targets. I do not think that is a blocker for stabilizing, but is something that may want to be considered in the future if those are things someone wants.

It is also not supported by the unstable artifact-dependencies and per-package-target feature (in the sense that they only allow selecting a single target). Also not a blocker, and also can be added at any time in the future. Just trying to note that this has a ripple effect across other features.

Rustdoc marks features as being only active for certain targets, and cargo install is meant for installing on the local machine, so neither cargo doc or cargo install really make any sense. The one exception I can think of is for WASM applications, you would want cargo install to build for WASM, but that seems a bit of a clunky use of cargo install anyways.

Lokathor · 2022-06-28T23:22:56Z

cargo install might be wanted to build for any platform with an emulator, but yes you probably don't need multitarget in that case, a project probably only supports that one platform.

ehuss · 2022-06-29T01:44:04Z

Yea, cargo install is probably not applicable.

However, for cargo doc I was thinking it would generate:

target/x86_64-apple-darwin/doc/…
target/aarch64-apple-darwin/doc/…

That is, equivalent to running cargo doc --target x86_64-apple-darwin && cargo doc --target aarch64-apple-darwin. I can't think of a good use case for that, though.

It would be interesting if rustdoc could union multiple target cfgs within the same documentation (without needing to do #[cfg(doc)] shenanigans like the standard library does).

rfcbot · 2022-07-08T16:11:39Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

9424: INT: generalize MatchToIfLetIntention to arbitrary arm count, take two r=vlad20012 a=Kobzol This PR is another attempt of implementing #7435. I learned that `if` expressions must have an `else` block if their type is anything other than `()`. So now the code always generates an `else` branch if it wasn't already generated by other means for match expressions that don't have unit type. Fixes: #7409 changelog: The intention to convert a match expression to a series of if let statements is now offered in more situations. 9958: IDE: add implementations Code Vision hint r=vlad20012 a=Kobzol The `handleClick` implementation is copied from `ImplsNavigationGutterIconRenderer::navigateToItems`. It should probably be placed into some unified location, but I'm not sure where does it belong. Relevant issue: #9427 changelog: Add support for showing implementations (inheritors) Code Vision. Note, these hints are available starting with 2022.3 and are currently disabled by default. You can turn it on via `Registry... | org.rust.code.vision.implementation`. 10685: #10125: Support multiple build targets in .cargo/config.toml r=vlad20012 a=mryall-mawson changelog: support multiple build.target values in .cargo/config.toml This is a fix for #10125, where the `cargo metadata` execution fails when multiple build targets are specified in `.cargo/config.toml`. Multiple build targets in config.toml were stabilized in Rust 1.64.0, as part of rust-lang/cargo#8176. As described in [my comment on the issue](#10125 (comment)), I have changed `buildTarget: String?` into `buildTargets: List<String>` in the `CargoConfig`, as returned by `Cargo.getConfig()`, and used in various places which calls that function. Instead of being `null`, `buildTargets` is an empty list if build.target is not specified, which is still correctly handled (defaulted to the host triple) by the calling code. As a result, `Cargo.fetchMetadata()` now passes `--filter-platform` multiple times to the `cargo metadata` call, rather than an empty string, which will correctly filter the dependencies for multiple target platforms, fixing the implementation originally added in #7185. Tests have been added and updated to exercise this functionality. This is my first time working on this project, so please feel free to adjust whatever is needed to take this forward. Co-authored-by: Jakub Beránek <[email protected]> Co-authored-by: Matt Ryall <[email protected]>

alexcrichton added C-bug Category: bug C-tracking-issue Category: A tracking issue for something unstable. and removed C-bug Category: bug labels Apr 28, 2020

ehuss added the A-cross-compiling Area: using --target flag for other platforms label Apr 29, 2020

This was referenced Apr 29, 2020

Multi-target build #8156

Closed

Support multiple targets #3913

Closed

volks73 mentioned this issue Nov 30, 2020

Obtain the Cargo compiler configuration for use in subcommands without building the package #8923

Closed

Ilia-Kosenkov mentioned this issue Dec 23, 2020

Update GitHub Actions extendr/extendr#90

Merged

cormacrelf mentioned this issue Apr 28, 2021

Support for macOS Universal/fat binaries #8875

Open

Mygod mentioned this issue Jun 20, 2021

Multi-target build mozilla/rust-android-gradle#32

Open

Airtz mentioned this issue Jul 22, 2021

Tracking Issue for per-package-target #9406

Open

3 tasks

repi mentioned this issue Nov 3, 2021

External tracking: multiple targets in single cargo process EmbarkStudios/rust-gpu#791

Open

5 tasks

This was referenced Feb 26, 2022

Allow for a way to package and sign executables #10430

Closed

Traverse Research Android tracking issues Traverse-Research/opensource-ecosystem#4

Open

Kixunil mentioned this issue Mar 1, 2022

Post-build script execution #545

Open

weihanglo mentioned this issue Mar 11, 2022

Support -Zmultitarget in cargo config #10473

Merged

epage mentioned this issue Jun 18, 2022

Stabilize -Zmultitarget #10766

Merged

weihanglo added the T-cargo Team: Cargo label Jun 18, 2022

rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Jun 18, 2022

rfcbot added the final-comment-period FCP — a period for last comments before action is taken label Jun 28, 2022

rfcbot removed the proposed-final-comment-period An FCP proposal has started, but not yet signed off. label Jun 28, 2022

rfcbot added the finished-final-comment-period FCP complete label Jul 8, 2022

rfcbot added to-announce and removed final-comment-period FCP — a period for last comments before action is taken labels Jul 8, 2022

bors closed this as completed in #10766 Jul 17, 2022

FrankYang0529 mentioned this issue Jul 20, 2022

test: add test cases for serve fermyon/spin-fileserver#15

Merged

osiewicz mentioned this issue Jun 6, 2023

chore: Enable ThinLTO zed-industries/zed#2548

Merged

mryall-mawson mentioned this issue Jul 14, 2023

#10125: Support multiple build targets in .cargo/config.toml intellij-rust/intellij-rust#10685

Merged

epage added this to Cargo Roadmap Sep 5, 2023

epage moved this to Done in Cargo Roadmap Sep 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issues for the `-Zmultitarget` feature #8176

Tracking issues for the `-Zmultitarget` feature #8176

alexcrichton commented Apr 28, 2020

4ad commented Nov 24, 2020

alexcrichton commented Nov 24, 2020

4ad commented Nov 24, 2020

khionu commented Jul 25, 2021 •

edited

Loading

Jasper-Bekkers commented Feb 27, 2022 •

edited

Loading

edwincoronado commented Mar 9, 2022

weihanglo commented Jun 18, 2022

rfcbot commented Jun 18, 2022 •

edited by ehuss

Loading

rfcbot commented Jun 28, 2022

ehuss commented Jun 28, 2022

khionu commented Jun 28, 2022

Lokathor commented Jun 28, 2022

ehuss commented Jun 29, 2022

rfcbot commented Jul 8, 2022

Tracking issues for the -Zmultitarget feature #8176

Tracking issues for the -Zmultitarget feature #8176

Comments

alexcrichton commented Apr 28, 2020

4ad commented Nov 24, 2020

alexcrichton commented Nov 24, 2020

4ad commented Nov 24, 2020

khionu commented Jul 25, 2021 • edited Loading

Jasper-Bekkers commented Feb 27, 2022 • edited Loading

edwincoronado commented Mar 9, 2022

weihanglo commented Jun 18, 2022

rfcbot commented Jun 18, 2022 • edited by ehuss Loading

rfcbot commented Jun 28, 2022

ehuss commented Jun 28, 2022

khionu commented Jun 28, 2022

Lokathor commented Jun 28, 2022

ehuss commented Jun 29, 2022

rfcbot commented Jul 8, 2022

Tracking issues for the `-Zmultitarget` feature #8176

Tracking issues for the `-Zmultitarget` feature #8176

khionu commented Jul 25, 2021 •

edited

Loading

Jasper-Bekkers commented Feb 27, 2022 •

edited

Loading

rfcbot commented Jun 18, 2022 •

edited by ehuss

Loading