-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for -Z crate-versions #7907
Comments
What needs to be done to stabilize both features (rustdoc's and cargo's parts)? |
First step would be to follow up with the rustdoc team to figure out if there is a reason it hasn't been stabilized, yet. Maybe ask on their channel on Discord? Also, I just thought of a concern about how it works. The standard library passes a custom string to the flag. If Cargo starts passing the flag, it will fail since the flag is passed multiple times. We'll need to figure out some solution for that. Offhand I don't have any ideas. If they're OK with dropping the git hash/date, then maybe we can just remove the custom code when building the standard library. Maybe follow up with the docs people about that, too. |
Stabilization in rustdoc has landed. |
@aleksator would you be willing to open a PR to stabilize this in Cargo? If not, that's ok, just wanted to check. |
@ehuss Sorry I wasn't available. Thank you for doing the PR, looks good to me. |
I'm happy this is finally in: it completes the first issue I picked up for Rust project. Thank you @ehuss for the guidance! |
Implementation: #7903
Original issue: #1681
Summary
-Z crate-versions
will add the crate version tocargo doc
via the unstable rustdoc flag.Unresolved issues
--crate-version
in rustdoc. DONE: Stabilize --crate-version option in rustdoc rust#69494--crate-version
to hit stable (1.44 on June 4th). (This is done so we don't have to query rustdoc if it supports the flag.)The text was updated successfully, but these errors were encountered: