Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for -Z crate-versions #7907

Closed
1 of 2 tasks
ehuss opened this issue Feb 19, 2020 · 6 comments · Fixed by #8509
Closed
1 of 2 tasks

Tracking issue for -Z crate-versions #7907

ehuss opened this issue Feb 19, 2020 · 6 comments · Fixed by #8509
Labels
C-tracking-issue Category: A tracking issue for something unstable. Command-doc

Comments

@ehuss
Copy link
Contributor

ehuss commented Feb 19, 2020

Implementation: #7903
Original issue: #1681

Summary

-Z crate-versions will add the crate version to cargo doc via the unstable rustdoc flag.

image

Unresolved issues

@ehuss ehuss added Command-doc C-tracking-issue Category: A tracking issue for something unstable. labels Feb 19, 2020
aleksator added a commit to aleksator/cargo that referenced this issue Feb 20, 2020
@aleksator
Copy link
Contributor

What needs to be done to stabilize both features (rustdoc's and cargo's parts)?
I'd be happy to do the required work.

@ehuss
Copy link
Contributor Author

ehuss commented Feb 23, 2020

First step would be to follow up with the rustdoc team to figure out if there is a reason it hasn't been stabilized, yet. Maybe ask on their channel on Discord?

Also, I just thought of a concern about how it works. The standard library passes a custom string to the flag. If Cargo starts passing the flag, it will fail since the flag is passed multiple times. We'll need to figure out some solution for that. Offhand I don't have any ideas. If they're OK with dropping the git hash/date, then maybe we can just remove the custom code when building the standard library. Maybe follow up with the docs people about that, too.

@aleksator
Copy link
Contributor

Stabilization in rustdoc has landed.
The next steps are to wait until it has reached rustc's stable branch and then it would be possible to pass the flag by default in cargo.

@ehuss
Copy link
Contributor Author

ehuss commented Jun 5, 2020

@aleksator would you be willing to open a PR to stabilize this in Cargo? If not, that's ok, just wanted to check.

@aleksator
Copy link
Contributor

@ehuss Sorry I wasn't available. Thank you for doing the PR, looks good to me.

@bors bors closed this as completed in dbbab42 Jul 23, 2020
@aleksator
Copy link
Contributor

I'm happy this is finally in: it completes the first issue I picked up for Rust project. Thank you @ehuss for the guidance!

@epage epage moved this to Done in Cargo Roadmap Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for something unstable. Command-doc
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants