Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TomlDependency should impl Clone #6526

Closed
dodomorandi opened this issue Jan 7, 2019 · 0 comments · Fixed by #6527
Closed

TomlDependency should impl Clone #6526

dodomorandi opened this issue Jan 7, 2019 · 0 comments · Fixed by #6527
Assignees
@dwijnand
Labels
C-bug Category: bug

Comments

@dodomorandi
Copy link

Problem
TomlDependency is not Clone, which is annoying when using cargo as a lib.

Possible Solution
Just add Clone to the derive attribute. Both String and DetailedTomlDependency are Clone, therefore it should be a trivial and a non-breaking change.
@dodomorandi dodomorandi added the C-bug Category: bug label Jan 7, 2019
@dwijnand dwijnand mentioned this issue Jan 7, 2019
Merged
@dwijnand dwijnand self-assigned this Jan 7, 2019
bors added a commit that referenced this issue Jan 7, 2019
@bors
Auto merge of #6527 - dwijnand:derive-Clone-for-TomlDependency, r=ehuss
64f0db3 
Derive Clone for TomlDependency

Fixes #6526
@bors bors closed this as completed in #6527 Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwijnand dwijnand

Labels
C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Derive Clone for TomlDependency dwijnand/cargo
2 participants
@dwijnand @dodomorandi