Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "epoch" to "edition" #5214

Closed
klnusbaum opened this issue Mar 20, 2018 · 5 comments
Closed

Rename "epoch" to "edition" #5214

klnusbaum opened this issue Mar 20, 2018 · 5 comments

Comments

@klnusbaum
Copy link
Contributor

In rust repo, we've started renaming all the references of "epoch" to "edition". At the request of @Manishearth, let's make any needed parallel changes here in the cargo project.
@Manishearth
Copy link
Member

(@klnusbaum is working on this)

@klnusbaum
Copy link
Contributor Author

I've got a PR ready for this. Just waiting for rust-lang/rust#49035 to land in the nightly

@Manishearth
Copy link
Member

Any progress?

@klnusbaum klnusbaum mentioned this issue Apr 1, 2018
Merged
@klnusbaum
Copy link
Contributor Author

I was actually just working on this.

Just put up a PR :)

@Manishearth Manishearth mentioned this issue Apr 2, 2018
Closed
bors added a commit that referenced this issue Apr 2, 2018
@bors
Auto merge of #5274 - klnusbaum:epoch_5214, r=alexcrichton
551f6f3 
rename epoch to edition

Per issue #5214 let's rename all instances of epoch to Edition
@matklad
Copy link
Member

matklad commented Apr 9, 2018

I believe this is fixed by #5274! 🎉

@matklad matklad closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klnusbaum @Manishearth @matklad