-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registry_auth::token_not_logged is failing randomly #12639
Labels
A-testing-cargo-itself
Area: cargo's tests
Comments
@rustbot assign @hi-rustin @hi-rustin indicated they may be able to look at this at #12624 (comment). Let me know if you have any questions or want me to take a look to give you any pointers. |
bors
added a commit
that referenced
this issue
Sep 22, 2023
Fix spurious errors with networking tests. This fixes an issue where some networking tests could behave erratically. In particular, the `registry_auth::token_not_logged` has been failing somewhat often (see #12639). The issue is that curl can behave inconsistently based on whether or not it immediately detects that the connection has closed or not, which is not done consistently. HTTP 1.1 defaults to `Connection: open`, so this mini HTTP server was essentially not standards compliant. `Connection: close` tells curl to expect the connection to close ([ref](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection)).
bors
added a commit
that referenced
this issue
Sep 23, 2023
Buffer console status messages. This adds buffering to some of the console output. This can help with interleaved output, particularly with things like the log output interleaving with status messages. This fixes that interleaving by atomically writing the entire status message, which in turn, helps fix some spurious errors such as #12639. I'm uncertain what the performance impact of this change might have. It might improve performance, since there should be a lot fewer syscalls, and I suspect terminals will be able to handle it more efficiently (and particularly across a network connection). However, I don't know if that will have a noticeable impact. Only the "status" messages are buffered. Everything else is still unbuffered as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The test
registry_auth::token_not_logged
has been failing in CI randomly, and I don't immediately have thoughts why.profile.release.package."*"
#12624 (comment)This issue has been assigned to @hi-rustin via this comment.
The text was updated successfully, but these errors were encountered: