Do not allow empty feature name

Signed-off-by: hi-rustin <[email protected]>
rust-lang · Nov 8, 2023 · dd3f434 · dd3f434
1 parent 4270265
commit dd3f434
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/cargo/core/summary.rs b/src/cargo/core/summary.rs
@@ -431,6 +431,9 @@ impl fmt::Display for FeatureValue {
 pub type FeatureMap = BTreeMap<InternedString, Vec<FeatureValue>>;
 
 fn validate_feature_name(pkg_id: PackageId, name: &str) -> CargoResult<()> {
+    if name.is_empty() {
+        bail!("feature name cannot be empty");
+    }
     let mut chars = name.chars();
     if let Some(ch) = chars.next() {
         if !(unicode_xid::UnicodeXID::is_xid_start(ch) || ch == '_' || ch.is_digit(10)) {
@@ -488,5 +491,6 @@ mod tests {
         assert!(validate_feature_name(pkg_id, "?foo").is_err());
         assert!(validate_feature_name(pkg_id, "ⒶⒷⒸ").is_err());
         assert!(validate_feature_name(pkg_id, "a¼").is_err());
+        assert!(validate_feature_name(pkg_id, "").is_err());
     }
 }