Improve terms defaults #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default values for --term-old and --term-new could use some reasonable defaults, here the mapping: | RegressOn | Old | New | | --------------------------------------------------------------- | | Error | "Successfully compiles" | "Compile error" | | Success | "Compile error" | "Successfully compiles" | | Ice | "Did not ICE" | "Found ICE" | | NonIce | "Found ICE" | "Did not ICE" | | NonError | "Compile error (no ICE)" | "Successfully compiles" | Suggested here: rust-lang#330 (comment)
|
Hm, doing some testing here I still find several situations where this displays the opposite of what it should. For example, when testing something that fails to compile on old compilers, and compiles successfully on newer ones, and using the I posted #339 with what my intentions were about how the old/new terms could be defaulted based on the regression mode. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @ehuss 👋
this patch tries to implement your suggestion (see comment) implementing reasonable defaults for
--term-oldand--term-new.I've tried doing something that would not lead to confusion but I find the implementation confusing the same 😄
Is it just me? Any suggestion on how to improve?
Thanks