-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit description of invalid array access #2454
Edit description of invalid array access #2454
Conversation
77dced6
to
7ed5071
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I'm pretty sure my wording can be improved. I'll let that job to other reviewers.
7ed5071
to
c19fe2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm okay with this (once the extra bolding is removed) but would like @carols10cents 's opinion too.
c19fe2d
to
97e2b16
Compare
@carols10cents can you please review this PR? |
Shouldn't it say
Instead of
Since the point of the example is to show compile-time safety? |
This issue has caused numerous issues and questions over the past couple months. Can we follow through with the review process? |
Yes of course, thanks for the suggestion |
97e2b16
to
a45c24b
Compare
@Amjad50 thank you so much for working on this! However, the point of this example is to show the runtime error and demonstrate that there are some safety checks that happen at runtime rather than compile time. I'd rather change the example to something along the lines of this example but not quite that... I'm not sure what yet though, I need some time to think about it. In the meantime, I'm going to close this PR because I don't think this is the direction we should go. |
Fix the description in response to a comment from the previous PR #2446 .
fixes #2417
Can you review? @Lonami, @steveklabnik