Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include example of public tuple struct and field #2051

Closed
wants to merge 1 commit into from

Conversation

nilslice
Copy link

@nilslice nilslice commented Aug 8, 2019

I love the book, thank you for all the effort to create and maintain it! I just encountered a puzzling compiler error in a project of mine, and realized maybe other newcomers like myself could avoid some confusion if an example such as this was included.

Reference of the issue I faced: rust-lang/rust#39703

If you think there is a better place for this kind of example (e.g. not as part of the book), no worries at all. Otherwise, please feel free to change/improve the example as you see fit.

@steveklabnik
Copy link
Member

Hey @nilslice ! I appreciate the PR. It's tough when you run into a bug, but I'm also not sure that this is a good addition to the book at this time; it's so big, we have to be really careful about additions, and I don't think this one pulls its weight. Maybe send a PR to Rust By Example instead?

Thank you again, and sorry I cannot accept this.

@nilslice
Copy link
Author

@steveklabnik - no worries! the compiler error message was fixed recently, which will make this particular case far less confusing for future learners.

Thanks for the explanation and suggestion though! I will take a look at submitting a PR for Rust By Example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants