Add close button to draft warning #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steveklabnik how do you feel about this? how close are we to just removing the warning...? |
|
Any news? I'd like to close this if you are not interested for housekeeping. |
|
ping @steveklabnik |
|
Let's |
. Thank you
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a close button to the warning about the second edition being a draft.
Clicking the button persists to the localStorage field
mdbook-draft-warningusing thestoreAPI. This approach has been adapted from the sidebar implementation.Motivation
I found myself being distracted by the same warning on each chapter. Especially when using a darker theme the bright red of the message takes aways a lot of attention from the often crucial introduction paragraphs.
Before
After