Printing backtrace ip for x86_64-fortanix-unknown-sgx #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,30 +198,32 @@ impl BacktraceFrameFmt<'_, '_, '_> { | |||
| // To reduce TCB size in Sgx enclave, we do not want to implement symbol | |||
| // resolution functionality. Rather, we can print the offset of the | |||
| // address here, which could be later mapped to correct function. | |||
| #[cfg(all(feature = "std", target_env = "sgx", target_vendor = "fortanix"))] | |||
There was a problem hiding this comment.
I think the removal of this feature directive will break this building when included into libstd?
| write!(self.fmt.fmt, "{:1$}", "", HEX_WIDTH + 3)?; | ||
| } | ||
| } | ||
|
|
||
| // Next up write out the symbol name, using the alternate formatting for | ||
| // more information if we're a full backtrace. Here we also handle | ||
| // symbols which don't have a name, | ||
| #[cfg(not(all(target_env = "sgx", target_vendor = "fortanix")))] |
There was a problem hiding this comment.
Could this use an if instead of using an attribute?
|
I need to take a look at https://github.com/nhynes/backtrace-rs/tree/fix-sgx |
|
@jethrogb Hello! Do you intend to pick up this PR again? Is this even still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what happened, this used to work.
cc @VardhanThigle