MSI initial support #2
Conversation
|
Wow! Thanks! |
| @@ -176,15 +180,26 @@ def run(args): | |||
| if channel == "stable": | |||
| CFG_RELEASE=CFG_RELEASE_NUM | |||
| CFG_PACKAGE_VERS=CFG_RELEASE_NUM | |||
| # UpgradeCode shoud stay the same for all MSI versions in channel | |||
| CFG_UPGRADE_CODE="1C7CADA5-D117-43F8-A356-DF15F9FBEFF6" | |||
There was a problem hiding this comment.
Do these upgrade codes mean that the MSI version of rust release channels can be installed simultaneously? Do the installers modify PATH in conflicting ways?
There was a problem hiding this comment.
Yes, they'd all end up on the PATH and then the first one wins. In order to support side-by-side installation of multiple Rust versions, we should probably consider leaving PATH alone (or at least making this feature not selected by default), and providing shortcuts in the Start menu that open console window with PATH set for the appropriate Rust version.
Another interesting question is whether 32-bit and 64-bit versions should be considered the same product. Right now they are, and installing, say, a 64-bit version uninstalls the 32-bit one (and vice-versa), which is kinda bad.
On the other hand, if we bundled both 32- and 64-bit versions of Rust libraries, there'd be no reason to want to install both, because one could just use the --target switch to select bitness of the generated executables.
There was a problem hiding this comment.
leaving PATH alone (or at least making this feature not selected by default
it's not selected by default write now. It has Level="5" which is higher than the default INSTALLLEVEL
|
It's unfortunate that this reproduces the text of LICENSE.txt, which chances with some regularity. Is there any way we can generate it from the original license source included in the binary tarballs? |
| Language="1033" | ||
| Version="$(env.CFG_MSI_VERSION)" | ||
| UpgradeCode="$(env.CFG_UPGRADE_CODE)" | ||
| Manufacturer="Mozilla Foundation"> |
There was a problem hiding this comment.
Should this be the Rust Project, or something?
There was a problem hiding this comment.
Yeah, "The Rust Project Developer" please.
|
@Arke64 says: " |
| @@ -44,6 +45,7 @@ def run(args): | |||
|
|
|||
| # Create the temp directory | |||
| if os.path.isdir(TEMP_DIR): | |||
| print "Removint old temp..." | |||
|
This PR looks like a decent starting point to me. I think we could merge it as-is, and then iterate on details. |
|
About |
brson
force-pushed
the
master
branch
3 times, most recently
from
730b3bf to
a20d18f
Compare
|
Needs a rebase. Sorry! |
|
Rebased |
|
I intend to test this this week. Sorry for the delay. |
This allows to choose install scope (permachine/peruser) and directory
|
Switched to WixUI_Advanced set of dialogs |
|
Merged. Thanks for being patient. |
Tested with WiX 3.9 and msys2 on
i686-pc-windows-gnutarget.Still need to replace some hardcodes by variables but that's a start.