forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not suggest adding a semicolon after
?
- Loading branch information
1 parent
81053b9
commit 9946ff2
Showing
3 changed files
with
67 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
src/test/ui/suggestions/try-operator-dont-suggest-semicolon.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Regression test for #87051, where a double semicolon was erroneously | ||
// suggested after a `?` operator. | ||
|
||
fn main() -> Result<(), ()> { | ||
a(|| { | ||
b() | ||
//~^ ERROR: mismatched types [E0308] | ||
//~| NOTE: expected `()`, found `i32` | ||
//~| HELP: consider using a semicolon here | ||
})?; | ||
|
||
// Here, we do want to suggest a semicolon: | ||
let x = Ok(42); | ||
if true { | ||
//~^ NOTE: expected this to be `()` | ||
x? | ||
//~^ ERROR: mismatched types [E0308] | ||
//~| NOTE: expected `()`, found integer | ||
//~| HELP: consider using a semicolon here | ||
} | ||
//~^ HELP: consider using a semicolon here | ||
|
||
Ok(()) | ||
} | ||
|
||
fn a<F>(f: F) -> Result<(), ()> where F: FnMut() { Ok(()) } | ||
fn b() -> i32 { 42 } |
33 changes: 33 additions & 0 deletions
33
src/test/ui/suggestions/try-operator-dont-suggest-semicolon.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
error[E0308]: mismatched types | ||
--> $DIR/try-operator-dont-suggest-semicolon.rs:6:9 | ||
| | ||
LL | b() | ||
| ^^^- help: consider using a semicolon here: `;` | ||
| | | ||
| expected `()`, found `i32` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/try-operator-dont-suggest-semicolon.rs:16:9 | ||
| | ||
LL | / if true { | ||
LL | | | ||
LL | | x? | ||
| | ^^ expected `()`, found integer | ||
LL | | | ||
LL | | | ||
LL | | | ||
LL | | } | ||
| |_____- expected this to be `()` | ||
| | ||
help: consider using a semicolon here | ||
| | ||
LL | x?; | ||
| ^ | ||
help: consider using a semicolon here | ||
| | ||
LL | }; | ||
| ^ | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0308`. |