Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more fields in beacon as pub #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tdittr
Copy link

@tdittr tdittr commented Oct 8, 2024

For a project I want to not just parse beacon frames but also send them. So I exposed all needed fields to create them.

Since the lists were represented by a pair of length and array, and I wanted to ensure it was impossible to have inconsistent state, I replaced those by heapless::Vec. Let me know if this dependency is ok for you.

This made some parts of the frames no longer Copy, but I think that is a good thing, since some structs got quite big to copy. (e.g. PendingAddress is 70 bytes)

This allows to not just parse but also generate these frames.
@tdittr tdittr marked this pull request as ready for review October 22, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants