-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo regress tool and move CI #905
Conversation
9d2df55
to
14da61b
Compare
I don't know if I can enable CI for my own fork, that would be useful for testing.. |
cc @Emilgardis |
1ea7ef0
to
7922184
Compare
matrix: | ||
# Options are all, none, strict and const | ||
include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could use a
outputs:
matrix: ${{ steps.generate-matrix.outputs.matrix }}
job
which would convert the matrix in this file to
strategy:
fail-fast: false
include: ${{ fromJson(needs.generate-matrix.outputs.matrix) }}
however, that wouldn't test different command flags. So maybe we shouldn't do that and instead just have a single job to test all defined test targets in svd2rust-regress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would the input specification via a different job help? Wouldn´t one command mean that there are no individual CI jobs for the architecture and flag options anymore? I think this is a good thing in the current setup.. I tried to preserve the old setup here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do this in cross-rs, where I have a targets.toml that populate the CI automatically through a ci job to filter targets.
The input basically expands to a list of targets, not just a single target in a list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would probably be useful to make running the tests as they are done in the CI locally, even though it makes the CI chain a bit more complex.. But it might be better for a different PR?
799ac32
to
3564036
Compare
- CI now uses the svd2rust-regress tool instead of a bash script - Fixed a bug where the workspace TOML file was still updated and changed when running the regression tool - Upgrade `portable-atomic` version for CI checks to 1. - Introduce MSRV v1.82.0 for the regress tool. - Allow passing multiple passthrough options to the regress tool. - Allow passing options using the test YAML file using the `opts` key - Allow specifying a suffix for test cases inside the YAML file using the `suffix` key. This can be used to resolve name duplications. - Allow skipping the `cargo check` for test cases with a `skip_check` key inside the YAML file
8fa38dd
to
17c74f3
Compare
I think this is getting to a good state now. The only problematic thing is that I had to disable the checks for MSP430. When I try to do a @burrbull I did not update the changelog, because this is only related to internal tooling. Should I still add a changelog entry? |
no changelog is needed for this |
Fixes #689 |
Let's merge this now. If there is more issues we can fix them in another PR
when running the regression tool
portable-atomic
version for CI checks to 1.opts
keysuffix
key.This can be used to resolve name duplications.
cargo check
for test cases with askip_check
keyinside the YAML file