Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DeriveFrom entry for address_block #289

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

emesare
Copy link
Contributor

@emesare emesare commented Feb 15, 2025

Fixes #288

I didn't look much into it, but i'm pretty sure we only copy the address blocks if the entry is absent in the derived info.

@emesare emesare requested a review from a team as a code owner February 15, 2025 00:47
@burrbull
Copy link
Member

@emesare emesare force-pushed the add_missing_addr_block_df branch from 2cd7274 to e0631d7 Compare February 16, 2025 00:03
@emesare
Copy link
Contributor Author

emesare commented Feb 16, 2025

Apologies for forgetting to format! Pushed formatted commit.

What would you like me to do in the Cargo.toml?

I went and looked around for a contributing doc and a Quick Look ™️ around I could not find a reference for what to update, my guess is either incrementing the version or adding an author entry, but I will await your response before I start committing nonsense 😆

Thanks for the quick response 😄

@burrbull
Copy link
Member

@emesare emesare force-pushed the add_missing_addr_block_df branch from e0631d7 to 378d237 Compare February 16, 2025 19:35
@emesare
Copy link
Contributor Author

emesare commented Feb 16, 2025

Done! :)

@burrbull burrbull added this pull request to the merge queue Feb 17, 2025
Merged via the queue into rust-embedded:master with commit ac586d0 Feb 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeriveFrom for PeripheralInfo missing address blocks
2 participants