Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nix to 0.14 to fix compilation issues #55

Merged
merged 2 commits into from
May 29, 2019

Conversation

ryankurte
Copy link
Contributor

@ryankurte ryankurte commented May 22, 2019

Waiting on: nix-rust/nix#1060 (comment)
See also: rust-embedded/linux-embedded-hal#17
Patching to git source tested to be working

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ryankurte
Copy link
Contributor Author

nix 0.14.x has landed and CI seems happy ^_^

@ryankurte ryankurte self-assigned this May 29, 2019
@posborne
Copy link
Member

Was going to comment on MSRV stuff again but the MSRV here is 1.26.0 and the MSRV for nix is 1.24.1 so we should be good to go.

@posborne
Copy link
Member

posborne commented May 29, 2019

bors r+

^^^ TODO: repo hasn't been borsified yet.

@posborne posborne merged commit f8e6484 into rust-embedded:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants