Use upstream nix #16
Merged
Use upstream nix #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an API change so we also include a major version bump along with this. Signed-off-by: Paul Osborne <[email protected]>
|
r? @nastevens (rust_highfive has picked a reviewer for you, use r? to override) |
This solves a number of issues and pulls in a variety of changes and improvements to the ioctl macros provided by nix. Signed-off-by: Paul Osborne <[email protected]>
posborne
force-pushed
the
use-upstream-nix
branch
from
22fa8d9 to
0b89f8b
Compare
asomers
reviewed
May 29, 2019
ryankurte
reviewed
May 29, 2019
| @@ -1,7 +1,7 @@ | |||
| language: rust | |||
| sudo: false | |||
| rust: | |||
| - 1.22.1 | |||
| - 1.26.0 # MSRV | |||
| - stable | |||
| - beta | |||
There was a problem hiding this comment.
do we need to test both beta and nightly? anything to decrease CI load is good atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the underlying work exposed by #15 related to rust-embedded/linux-embedded-hal#17
CC @ryankurte @asomers