Add proxy definition for download #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @maximilien-baumann! Would it be worth adding |
Depending of the network, proxies can be necessary to go on internet To allow download, keep proxies environment variable Signed-off-by: Maximilien Baumann <[email protected]>
maximilien-baumann
force-pushed
the
support_for_proxies
branch
from
9124caf to
86a8b8c
Compare
|
Yes good point, depending of the protocol of the package it can be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Depending of the network, proxies can be necessary to go to internet and be able to download external resources.
To allow download, keep proxies environment variable.
If there is no env var, values will be empty and have impact on the build.