Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump embedded-hal to rc 2 #104

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Bump embedded-hal to rc 2 #104

merged 3 commits into from
Dec 9, 2023

Conversation

CBJamo
Copy link
Contributor

@CBJamo CBJamo commented Nov 30, 2023

No description provided.

@CBJamo CBJamo requested a review from a team as a code owner November 30, 2023 20:20
@tommy-gilligan
Copy link
Contributor

looks good to me 👍

eldruin
eldruin requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The conversion is missing, though.
Could you also add an entry to the changelog about the update to embedded-hal?

src/spi.rs Outdated Show resolved Hide resolved
@eldruin eldruin mentioned this pull request Dec 8, 2023
Closed
eldruin
eldruin approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@eldruin eldruin added this pull request to the merge queue Dec 9, 2023
Merged via the queue into rust-embedded:master with commit da2649b Dec 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CBJamo @tommy-gilligan @eldruin