Skip to content

Commit

Permalink
Merge #17
Browse files Browse the repository at this point in the history
17: Remove #[deny(warnings)] r=therealprof a=dbrgn

The library currently does not currently build anymore, because upstream libraries have added new deprecation warnings. A deprecation warning should not break compilation though. There was a post on Reddit about this about a year ago, but I can't find it anymore.

I think adding a CI check step would be fine, but `#[deny(warnings)]` is a bit too much.

These are the warnings:

```
warning: use of deprecated item 'hal::digital::OutputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/lib.rs:111:6                                                       
    |                                                                         
111 | impl hal::digital::OutputPin for Pin {                                  
    |      ^^^^^^^^^^^^^^^^^^^^^^^                                            
    |                                                                         
    = note: #[warn(deprecated)] on by default                                 
                                                                              
warning: use of deprecated item 'hal::digital::InputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/lib.rs:121:6                                                       
    |                                                                         
121 | impl hal::digital::InputPin for Pin {                                   
    |      ^^^^^^^^^^^^^^^^^^^^^^                                             
                                                                              
warning: use of deprecated item 'hal::digital::InputPin::is_high': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/lib.rs:131:15                                                      
    |                                                                         
131 |         !self.is_high()                                                 
    |               ^^^^^^^                                                                                                                             
```

Co-authored-by: Danilo Bargen <[email protected]>
bors[bot] and dbrgn committed Jun 6, 2019
2 parents 2960715 + 9313b7f commit a81c005
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@
//! [0]: https://crates.io/keywords/embedded-hal
#![deny(missing_docs)]
#![deny(warnings)]

extern crate cast;
extern crate embedded_hal as hal;

0 comments on commit a81c005

Please sign in to comment.