Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method drain for Vec #365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add method drain for Vec #365

wants to merge 1 commit into from

Conversation

remme123
Copy link

Closes #334

@Dirbaio Dirbaio marked this pull request as draft October 31, 2023 00:00
Dirbaio
Dirbaio requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have the same API as std Vec's drain.

  • Take a range, so you can drain from the middle, not just from the start.
  • Return an iterator that gets the drained elements.

@reitermarkus reitermarkus mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add method drain for Vec, like std::vec::Vec?
2 participants
@remme123 @Dirbaio