Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A variety of minor cleanups #92

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

A variety of minor cleanups #92

wants to merge 5 commits into from

Conversation

noncombatant
Copy link

Fix some typos, Markdown, rustfmt, and use a (necessary) double dash for --version.

A variety of minor cleanups
df22657 
Fix some typos, Markdown, `rustfmt`, and use a (necessary) double dash
for `--version`.
@noncombatant noncombatant requested a review from a team as a code owner August 28, 2024 19:09
BartMassey
BartMassey requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@BartMassey BartMassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good — thanks much for the contribution. I've suggested a few changes…

src/asm.md Outdated Show resolved Hide resolved
src/dma.md Outdated Show resolved Hide resolved
src/logging.md Outdated Show resolved Hide resolved
src/logging.md Outdated Show resolved Hide resolved
@noncombatant
Copy link
Author

Thanks! I've incorporated your suggestions.

@BartMassey BartMassey self-requested a review August 29, 2024 03:00
BartMassey
BartMassey approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@BartMassey BartMassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

eldruin
eldruin reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change.
However, the CI seems broken. I opened #93.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin left review comments

@BartMassey BartMassey BartMassey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noncombatant @eldruin @BartMassey