Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add triagebot configuration #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add triagebot configuration #65

wants to merge 1 commit into from

Conversation

LeSeulArtichaut
Copy link

This enables assignment through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

@LeSeulArtichaut LeSeulArtichaut requested a review from a team as a code owner April 13, 2020 12:29
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Apr 13, 2020
ryankurte
ryankurte approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Apr 14, 2020
@bors @LeSeulArtichaut
Merge #65
35b9588 
65: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2020

Build failed:

@jamesmunns
Copy link
Member

Hey @jonas-schievink, this is complaining about a change in generated assembly code. Is this due to the "don't mangle the LR when panicking" change? Should we fix the expected generated ASM here?

@jonas-schievink
Copy link

Looks like it, yeah

@jamesmunns
Copy link
Member

Note: will probably need to be rebased on #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankurte ryankurte ryankurte approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@thejpster thejpster

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LeSeulArtichaut @rust-highfive @jamesmunns @jonas-schievink @ryankurte @thejpster