Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itm: derive serde for LocalTimestampOptions, impl gated TryFrom<u8> #366

Merged
merged 2 commits into from
Dec 31, 2021
Merged

itm: derive serde for LocalTimestampOptions, impl gated TryFrom<u8> #366

merged 2 commits into from
Dec 31, 2021

Conversation

tmplt
Copy link
Contributor

@tmplt tmplt commented Dec 7, 2021

This PR is an upstream push of more std-features required by cargo-rtic-scope. If required, the TryFrom<u8> impl can be kept downstream.

@tmplt
itm: derive serde for LocalTimestampOptions, impl gated TryFrom<u8>
bcb76ef
@tmplt
feature gates: std-map -> std
3b44533 
The alternative is to create another std-* gate for each std-related
functionality. I do not think this will scale well, and makes the crate
difficult to use.

If the end-user wants to use host-side functionality they will only need
to specify "std".
@tmplt tmplt requested a review from a team as a code owner December 7, 2021 12:17
@rust-highfive
Copy link

r? @therealprof

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Dec 7, 2021
@tmplt tmplt mentioned this pull request Dec 7, 2021
Merged
@tmplt tmplt mentioned this pull request Dec 17, 2021
Open
adamgreig
adamgreig approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems fine to me. I've also backported renaming std-map to std for the upcoming v0.7.4 branch so it's not a surprise change from 0.7 to 0.8 (though I doubt anyone will be using what's in 0.7 anyway...).

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 31, 2021

Build succeeded!

And happy new year! 🎉

@bors bors bot merged commit cde498d into rust-embedded:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmplt @rust-highfive @adamgreig @therealprof