Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Suspend state transition to go back to the previous state (#96) #97

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Fix Suspend state transition to go back to the previous state (#96) #97

merged 1 commit into from
Jun 19, 2022

Conversation

haata
Copy link
Contributor

@haata haata commented Jun 10, 2022 •
edited by eldruin
Loading

@haata haata force-pushed the fix_prev_suspend_state branch from ac9b4e2 to 4bda63a Compare June 10, 2022 19:18
@haata
Fix Suspend state transition to go back to the previous state (rust-e…
f56e425 
…mbedded-community#96)

- Per (https://ww1.microchip.com/downloads/en/DeviceDoc/Atmel-11100-32-bit%20Cortex-M4-Microcontroller-SAM4S_Datasheet.pdf; 40.6.3 page 1042), the state transition from Suspend should go back to the previous state
- Previously Suspend would always transition back to Default state
@haata haata force-pushed the fix_prev_suspend_state branch from 4bda63a to f56e425 Compare June 10, 2022 19:21
eldruin
eldruin approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@eldruin eldruin merged commit eaf9709 into rust-embedded-community:master Jun 19, 2022
@haata haata deleted the fix_prev_suspend_state branch June 19, 2022 19:19
@ithinuel ithinuel mentioned this pull request Jul 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does Suspend always transition to Default on Resume?
2 participants
@haata @eldruin