Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn repository into workspace and separate the tests #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Aug 9, 2022

Reading through #100 and #101, here is a PR turning this repository into a workspace. The idea would be that if @ianrrees and @Disasm agree, we could incorporate their device-side testing suite implementations into this repository so that everything is in a single place.
The directory structure would be:

|- usb-device                      // main crate
|- tests                           // test suite
    |- test_class_host             // host-side program
    |- <stm32xxxx>_device_tests    // device-side impl for some stm32 devices
    |- <atsamdxxxxx>_device_tests  // device-side impl for some atsamd devices

For now I just linked the repositories in the readme like in #101.
This includes the text from #101 as well. I hope that is fine with @ianrrees.
I do not care about the names of the device test folders. Feel free to propose a new one.
Thoughts?

cc: @ryan-summers

Copy link
Member

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is what I had in mind as well, thanks for going through the work of restructuring! :)

@eldruin
Copy link
Member Author

eldruin commented Aug 9, 2022

Opinions @ianrrees and @Disasm?

@ianrrees
Copy link
Contributor

ianrrees commented Aug 9, 2022

This includes the text from #101 as well. I hope that is fine with @ianrrees.

Yep, totally fine!

I'll aim to put some more thoughts in #100 later today.

@ianrrees
Copy link
Contributor

Just a thought: what if we set up the host side test program as a normal bin? I think that could allow a HAL developer to do something like cargo install usb-device to get the host-side test suite.

@Disasm
Copy link
Member

Disasm commented Aug 14, 2022

This looks like a better solution compared to what we have now, thank you!

@Finomnis
Copy link
Contributor

This is over a year old, what happened?

@ryan-summers
Copy link
Member

ryan-summers commented Sep 11, 2023

I believe the desire was lost and it now has a bunch of conflicts. usb-device isn't super well maintained - I review PRs in my spare time, but don't have time to do any active development on it.

@ianrrees
Copy link
Contributor

Exactly, @ryan-summers - Rust USB device stuff has been on my "next month or two" list for about two years now... What we have is a good start, but it could definitely use some focused attention.

@Finomnis
Copy link
Contributor

Rust USB device stuff has been on my "next month or two" list for about two years now...

Understandable, though. I'll also revert back to "good enough" once my usecase is fulfilled. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants