-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add first draft ethernet support #17
base: master
Are you sure you want to change the base?
Conversation
4c08f11
to
9546379
Compare
Hey! How's this one coming along? |
Still very much a work in progress, but it does work! Next steps are I think to find some time to sit down, and simplify / tidy this as much as possible. Then it should be ready for at least a first attempt at reviewing. Independently, I still need to have a think about rust-embedded/wg#278 (comment), and whether I want to write up some ideas for how that should be integrated, the intial draft in https://github.com/dtwood/svd2rust/tree/ephy and https://github.com/dtwood/svd2rust/tree/edes breaks the rest of svd2rust. And I think there should probably be some sort of template support for weirder cases like these, so that the they can stay out of tree and the templates provided along with the libraries instead. Maybe at some point I'll find some time to type that all up somewhere 🙂 |
If you find some time, I think this now in a state where I'm mostly happy with it, and would be ready for a first pass review. Things that are still outstanding are to push the revision of vcell forwards to compile on stable (currently blocked on a release including japaric/vcell#4), and to add an 'ethernet' feature flag, that will pull in smoltcp. One other thought is whether this driver should actually be a separate crate (tm4c129x-eth), like the https://github.com/stm32-rs/stm32-eth crate? |
Neat! I will try and find time to look at this soon :)
|
@@ -28,6 +28,10 @@ pub use tm4c_hal::bb; | |||
pub use tm4c_hal::delay; | |||
pub use tm4c_hal::time; | |||
|
|||
pub mod edes; | |||
mod edes_old; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's edes_old for?
Shall we try and push this one over the line? Ethernet support might be useful for another project I'm working on... |
No description provided.